areusch commented on issue #6653:
URL: https://github.com/apache/incubator-tvm/issues/6653#issuecomment-706342580


   it's probably aborting because an exception was raised while unwinding the 
stack because of a different exception?
   
   I don't think you need to actually raise the exception in the destructor 
here to get what you want. I think you can work around it and raise the 
exception in the Visitor instead of the Entry, unless there are other Visitor 
usages outside of `attr.h` i'm not seeing. it won't be automatic (I.e. the 
visitor will have to explicitly check that there were no problems in the 
visit), but i think explicitly specifying where a CHECK fail may occur is 
better than letting it occur randomly (i.e. whenever the c++ compiler decides 
to free the Entry) based on user input. see my previous post.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to