masahi edited a comment on issue #6594: URL: https://github.com/apache/incubator-tvm/issues/6594#issuecomment-706472689
@kevinthesun @jroesch @lixiaoquan @MarisaKirisame I found that this change was introduced in https://github.com/apache/incubator-tvm/pull/5795 If I make that above change, that effectively undos that PR and breaks the test case introduced there. Basically, what we want from type checking `If` involving both static and dynamic shape are complete opposite to the motivation of #5795. What should we do about this? Since type inference is supposed to pick the most general types, I think what we want is the right one and the change in #5795 should be reverted. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
