areusch commented on a change in pull request #6703:
URL: https://github.com/apache/incubator-tvm/pull/6703#discussion_r510373932



##########
File path: python/tvm/target/target.py
##########
@@ -220,19 +220,24 @@ def intel_graphics(model="unknown", options=None):
     return Target(" ".join(["opencl"] + opts))
 
 
-def micro(hardware="unknown", options=None):
+def micro(model="unknown", options=None):

Review comment:
       here i'm really just changing the name of an argument. most people pass 
this arg as a positional arg, so I don't know that there is much user-visible 
change. if you really want me to move it outside this change, I can, but 
jenkins takes 4-6 hours these days and we'd have to write a test here to get it 
to fail with this change.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to