d-smirnov commented on a change in pull request #6724:
URL: https://github.com/apache/incubator-tvm/pull/6724#discussion_r510755137
##########
File path: include/tvm/relay/op_attr_types.h
##########
@@ -185,6 +185,20 @@ using FTVMLegalize = runtime::TypedPackedFunc<Expr(const
Attrs& attrs, const Arr
using FTVMAnnotateTarget = runtime::TypedPackedFunc<bool(const Attrs& attrs,
// NOLINT(*)
const Array<Expr>&
args)>;
+/*!
+ * \brief Annotates an expression to indicate if an op should be compiled using
+ * the given compiler/target.
+ * \param attrs The attribute of the original expr.
+ * \param args The arguments of the original expr.
+ * \param out_type The return type of the original expr.
+ *
+ * \return true if this op should be registered to invoke a specific compiler
+ * for codegen, otherwise, false.
+ */
+using FTVMAnnotateTarget3 =
Review comment:
The goal was to minimize changes to other existing runtimes (which is
obviously not possible in case of `FTVMAnnotateTarget =
runtime::TypedPackedFunc<bool(const Expr&)>`). Otherwise it looks to me as
separate PR for this generalisation. What would be your advice here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
