tqchen commented on a change in pull request #6753:
URL: https://github.com/apache/incubator-tvm/pull/6753#discussion_r511619874
##########
File path: src/arith/iter_affine_map.cc
##########
@@ -351,31 +367,45 @@ class IterMapRewriter : public ExprMutator {
std::vector<IterSplitExpr> iters;
iters.reserve(expr->args.size());
// canonicalize the expression
+ // find the base scale first
+ IntImm base_scale(nullptr);
Review comment:
Use Optional<IntImm> to better express our intent that base_scale is not
defined in the begining. This can make things better for future cases when we
make IntImm not nullable
Alternatively, we can make base_index int64, and use base_index == -1 to
determine that we have not yet find the solution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
