giuseros commented on a change in pull request #6783:
URL: https://github.com/apache/incubator-tvm/pull/6783#discussion_r513384321
##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -788,6 +788,14 @@ def _impl(inputs, attr, params, mod):
return _impl
+def _expm1():
Review comment:
Could you add the docstring describing what this operation is doing?
##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -788,6 +788,14 @@ def _impl(inputs, attr, params, mod):
return _impl
+def _expm1():
+ def _impl(inputs, attr, params, mod):
+ lh = get_relay_op("exp")(inputs[0])
+ return get_relay_op("subtract")(lh, tvm.relay.const(1, attr["T"].name))
Review comment:
Not entirely sure, but can't you write `return lh -1`? Isn't there an
overload for the `-` operator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
