tom-gall commented on a change in pull request #6789:
URL: https://github.com/apache/incubator-tvm/pull/6789#discussion_r513742956
##########
File path: python/tvm/target/target.py
##########
@@ -220,19 +220,24 @@ def intel_graphics(model="unknown", options=None):
return Target(" ".join(["opencl"] + opts))
-def micro(hardware="unknown", options=None):
+def micro(model="unknown", options=None):
"""Returns a microTVM target.
Parameters
----------
- hardware : str
- Canonically identifies the target device; typicaly one of cortex-mX,
or a specific SoC model
- when that model has been tested to work with microTVM.
+ model : str
+ Canonically identifies the target device. This is typically a CPU or
board level name (other
+ flags such as -mcpu identify the ISA).
options : str or list of str
Additional options
"""
- trans_table = {"host": ["-mcpu=native"]}
- opts = _merge_opts(trans_table[hardware] + ["-runtime=c", "--system-lib"],
options)
+ trans_table = {
Review comment:
Someday we're going to have to / want to work with targets other then
cpu. Having a per board hard code here makes me a little uneasy. Should we be
open to a board / -mcpu setting passed in to override or add to the
trans_table?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
