[GitHub] [incubator-tvm] zhiics commented on a change in pull request #6697: [BYOC] Allow custom codegens to register their own constant updater

[GitBox]

zhiics commented on a change in pull request #6697:
URL: https://github.com/apache/incubator-tvm/pull/6697#discussion_r514336095



##########
File path: src/relay/backend/graph_runtime_codegen.cc
##########
@@ -371,10 +371,28 @@ class GraphRuntimeCodegen : public 
backend::MemoizedExprTranslator<std::vector<G
 
       // Step into the functions that are handled by external codegen to
       // collect metadata.
+      auto codegen = func->GetAttr<String>(attr::kCompiler);
+      CHECK(codegen.defined()) << "No external codegen is set";
+      std::string codegen_name = codegen.value();
       const auto name_node = func->GetAttr<String>(tvm::attr::kGlobalSymbol);
-      std::string symobl = std::string(name_node.value());
-      ConstantUpdater const_visit(symobl, &params_);
-      const_visit(func);
+      std::string symbol = std::string(name_node.value());
+      std::string const_update_name = "relay.ext." + codegen_name + 
".constant_updater";

Review comment:
       I am saying that we probably don't want to duplicate the code in both 
compiler.cc and build_module.cc. Instead, we can move it into ConstantUpdater 
so that difference places can share the same code. I am not saying these two 
lines are not needed.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org