jroesch commented on a change in pull request #6741:
URL: https://github.com/apache/incubator-tvm/pull/6741#discussion_r517789274
##########
File path: rust/tvm-rt/src/array.rs
##########
@@ -82,6 +82,13 @@ impl<T: IsObjectRef> Array<T> {
}
}
+impl<T: IsObjectRef> std::fmt::Debug for Array<T> {
+ fn fmt(&self, formatter: &mut std::fmt::Formatter) -> std::fmt::Result {
+ let as_vec: Vec<T> = self.clone().into_iter().collect();
Review comment:
its just cheaper to clone the outer smart pointer because we only modify
one reference count instead of touching the ref count on every single element.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
