tqchen commented on a change in pull request #6823: URL: https://github.com/apache/incubator-tvm/pull/6823#discussion_r518745251
########## File path: src/tir/transforms/loop_partition.cc ########## @@ -40,9 +40,13 @@ namespace tir { struct LoopPartitionConfigNode : public tvm::AttrsNode<LoopPartitionConfigNode> { bool partition_const_loop; + bool no_unroll_single_iter_loop; Review comment: how about `no_unroll_loop_with_extent_one` , since single iter can be ambiguious ########## File path: src/tir/transforms/loop_partition.cc ########## @@ -40,9 +40,13 @@ namespace tir { struct LoopPartitionConfigNode : public tvm::AttrsNode<LoopPartitionConfigNode> { bool partition_const_loop; + bool no_unroll_single_iter_loop; Review comment: how about `no_unroll_loop_with_extent_one` , since single iter can be ambiguous ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org