lixiaoquan commented on a change in pull request #6890:
URL: https://github.com/apache/incubator-tvm/pull/6890#discussion_r526577147
##########
File path: python/tvm/relay/prelude.py
##########
@@ -383,6 +383,12 @@ def define_tensor_array_scatter(self, indices_shape=None,
force_update=False):
return
tensor_array_scatter_helper_name =
self.get_name("tensor_array_scatter_helper")
+
+ if indices_shape:
Review comment:
Please see this line
https://github.com/apache/incubator-tvm/blob/7649075fbb71ecab0a41c6fe4d41a86724e42e7a/python/tvm/relay/prelude.py#L425
force_update works, and scatter funciton in mod is replaced, but the
original one for first scatter will be needed too.
Consider the case I added, there are two scatters in this case. If we don't
put indices into name, tensor_array_scatter_var will be the same for two
scatters, but Function will be different because of different indices. The
first function is overrided by the second one, and the second Function can't
match the first scatter's type.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
