manupa-arm commented on a change in pull request #6917: URL: https://github.com/apache/incubator-tvm/pull/6917#discussion_r526829285
########## File path: src/relay/backend/graph_runtime_codegen.cc ########## @@ -56,7 +56,7 @@ struct LoweredOutput { std::string graph_json; Map<String, IRModule> lowered_funcs; Array<tvm::runtime::Module> external_mods; - std::unordered_map<std::string, tvm::runtime::NDArray> params; + std::unordered_map<std::string, std::pair<int, const tvm::runtime::NDArray>> params; Review comment: This change will affect UpdateConstants() in line 379. Either we need to modify the UpdateConstants function or have something similiar to param_storage_ids in LoweredOutput separately. Am I missing something here @zhiics @comaniac ? The CI did not break anything. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org