giuseros commented on a change in pull request #6949:
URL: https://github.com/apache/incubator-tvm/pull/6949#discussion_r528806931



##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -1599,6 +1599,9 @@ def _impl(inputs, attr, params, mod):
         data_shape = get_const_tuple(in_type.checked_type.shape)
         data_dim = len(data_shape)
         stride_dim = len(stride)
+        if data_dim == 0 and isinstance(inputs[0], _expr.Constant):

Review comment:
       I suspect this is `data_dim==1`, right? Otherwise, the data would just 
be empty. Also, could you add a test case  to check this situation? In general, 
every new feature should come with an appropriate test (see the guidelines : 
https://tvm.apache.org/docs/contribute/pull_request.html)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to