jroesch commented on a change in pull request #7029:
URL: https://github.com/apache/tvm/pull/7029#discussion_r535742798
##########
File path: tests/python/relay/test_pass_dead_code_elimination.py
##########
@@ -91,62 +138,107 @@ def use_f(func):
return relay.Let(f, value, func(f))
-# make sure we dont infinite loop
-def test_recursion():
+def test_live_recursion():
+ before_program = """
+ #[version = "0.0.5"]
+ def @main() {
+ let %f = fn (%n: int, %data: int) -> int {
+ if (%n == 0) {
+ %data
+ } else {
+ %f(%n - 1, log(%data))
+ }
+ };
+ %f(2, 10000)
+ }
+ """
+
+ after_program = """
+ #[version = "0.0.5"]
+ def @main() {
+ let %f = fn (%n: int, %data: int) -> int {
+ if (%n == 0) {
+ %data
+ } else {
+ %f(%n - 1, log(%data))
+ }
+ };
+ %f(2, 10000)
+ }
"""
- Program:
- let f(n: i32, data: f32) -> f32 = {
- if (n == 0) {
- return data;
- } else {
- return f(n - 1, log(data));
- }
- }
- f(2, 10000);
+
+ optimize_and_check(
+ before_program, after_program, [transform.DeadCodeElimination(),
transform.InferType()]
+ )
+
+
+def test_dead_recursion():
+ before_program = """
+ #[version = "0.0.5"]
+ def @main() {
+ let %f = fn (%n: int, %data: int) -> int {
+ if (%n == 0) {
+ %data
+ } else {
+ %f(%n - 1, log(%data))
+ }
+ };
+ ()
+ }
"""
- orig = use_f(lambda f: relay.Call(f, [relay.const(2),
relay.const(10000.0)]))
- dced = run_opt_pass(orig, transform.DeadCodeElimination())
- orig = run_opt_pass(orig, transform.InferType())
- tvm.ir.assert_structural_equal(dced, orig)
+ after_program = """
+ #[version = "0.0.5"]
+ def @main() {
+ ()
+ }
+ """
-def test_recursion_dead():
- x = relay.Let(e.a, e.one, e.three)
- dced_f = lambda f: x
- dced = run_opt_pass(use_f(dced_f), transform.DeadCodeElimination())
- assert tvm.ir.structural_equal(dced, e.three)
+ optimize_and_check(
+ before_program, after_program, [transform.DeadCodeElimination(),
transform.InferType()]
+ )
-def test_op_let():
- dced = run_opt_pass(add(relay.Let(e.a, e.one, e.three), e.two),
transform.DeadCodeElimination())
- assert tvm.ir.structural_equal(dced, add(e.three, e.two))
+def test_dead_recursion():
+ before_program = """
+ #[version = "0.0.5"]
+ def @main() {
+ (let %a = 1; 3) + 2
+ }
+ """
+ after_program = """
+ #[version = "0.0.5"]
+ def @main() {
+ 3 + 2
+ }
+ """
-def test_tuple_get_item():
- tt = relay.TupleType([e.float32, e.float32])
- t = relay.Var("t", tt)
- a = relay.Var("a")
- g = relay.TupleGetItem(t, 0)
- dced = run_opt_pass(g, transform.DeadCodeElimination())
- assert tvm.ir.structural_equal(Function(free_vars(dced), dced),
Function(free_vars(g), g))
- orig = relay.TupleGetItem(relay.Let(a, e.one, t), 0)
- dced = run_opt_pass(orig, transform.DeadCodeElimination())
- assert tvm.ir.structural_equal(Function(free_vars(dced), dced),
Function(free_vars(g), g))
+ optimize_and_check(
+ before_program, after_program, [transform.DeadCodeElimination(),
transform.InferType()]
+ )
[email protected](timeout=10, method="thread")
-def test_complexity():
Review comment:
No these are not good tests, they don't really assert anything except
that this thing isn't like crazy slow and slows CI down by running passes
against large models is why CI performance is really bad.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
