Laurawly edited a comment on issue #6629: URL: https://github.com/apache/tvm/issues/6629#issuecomment-739731422
@alec-anyvision Thanks for pointing this issue out. The changes made were explained in PR #5339. So in the original implementation, `get_valid_count` will rearrange the invalid boxes to the end of the array while in the updated implementation, this movement is done by `argsort` to improve the performance. `valid_count` is changed to initialized to `None` in order to let `argsort` sort the entire array instead of only the first `valid_count` number of elements. Since `argsort` doesn't make changes to `valid_count`, I'm not sure why running `nms` multiple times will manifest the number of valid boxes. Could you elaborate more? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
