altanh commented on pull request #6798: URL: https://github.com/apache/tvm/pull/6798#issuecomment-740251072
I've addressed the ADT tag issue as suggested (using Tuple), and left a TODO comment in DCE. For the record, I tried adding Feature set checking in DCE to error on detecting RefWrite. However, the VM compilation process requires DCE in other places (I think most critically in `InlinePrimitives`), so I couldn't get the test to pass without removing feature checking. I think this raises the criticality of fixing DCE slightly, and we are working on it. re @mbrookhart , I'm not totally sure what you meant by the debug stuff, but references have been in Relay since higher-order AD was introduced. I'm not sure if there is/was an RFC for adding references, although I agree we should probably make one especially as we are working towards supporting stateful stuff going forward. cc @jroesch who might have more thoughts ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
