tqchen edited a comment on pull request #7060: URL: https://github.com/apache/tvm/pull/7060#issuecomment-740757459
Thanks @yongwww . I think it worth discussing the approach a bit further. Given that the relay operators are already accessible as part of the API, and the HLO and relay are pretty close, perhaps we want to statr by directly translate the HLO to relay in c++ without introducing the additional relay dialect step. The translation from MLIR/HLO to relay is going to be quite close to translation from a relay dialect to relay. This will help to reduce the number of places that are required to define a new operator. Given that the relay's operator set is growing. It will also likely makes the control flow and recursion translation more streamlined. A transition to a relay dialect(if we decided to) should not be too hard later, in that case we should also start to think more about a formal operator spec description, so we can generate the tablegen def later if necessary. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
