masahi commented on pull request #7056:
URL: https://github.com/apache/tvm/pull/7056#issuecomment-741047455
I see, you are right, the current way of directly calling thrust sort from
higher level op like scatter is not ideal. Dispatching decisions should be left
to `topi.sort`, yes.
One tricky bit is, what I need here is not exactly `topi.sort`, but more
specific one like `topi.stable_sort_by_key`. Similar to this case, I imagine
each higher level op could end up utilizing sorting in a customized way, so one
`topi.sort` may not suffice.
Being able to introduce and use customized sorting op by directly dropping
into low level libs is certainly convenient, as demonstrated in this PR,
although I have to admit it is a bit ad hoc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
