srkreddy1238 commented on issue #4102: URL: https://github.com/apache/tvm/issues/4102#issuecomment-741497324
TF 2.x differs at the front facing API level but the end graph doesn't change a lot here. Doing a fresh parser will duplicate most of the layers we have till today. I think we may end up with a lot of redundant work. My understanding and advice: - TF2.x official format is saved model. - TF2.x parser in my understanding should support inputs as (saved_model, signature name, input_spec) : Saved model input (concrete_function, input_spec) : Manually built TF Function. (TF Hub, input_spec) : A TFHub URL directly - Parsing any of these input options finally goes through grappler and results in a grapph_def. - There is no difference in this graph_def here and the existing parser does the job here. - The additional layers (TensorList, VarHandles, etc.) could follow the existing implementation at node level. TF2.x brings in standardization without the need of additional arguments like inputs, outputs, shapes(few cases) ..etc to be given by the user manually like we earlier asked for. I think TF2.x is an enhancement or amendment over 1.x parser than a replacement. Ref. https://github.com/srkreddy1238/tvm/tree/tf2.0 has the implementation. - This branch is outdated and I need to rebase it. - The 2.0 parser is part of the test script here. - I will need to clean it bit and will send a PR soon as a baseline. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
