FrozenGene commented on a change in pull request #7053:
URL: https://github.com/apache/tvm/pull/7053#discussion_r539004649



##########
File path: python/tvm/auto_scheduler/measure.py
##########
@@ -276,13 +279,16 @@ class LocalBuilder(ProgramBuilder):
     timeout : int = 15
         The timeout limit (in second) for each build thread.
         This is used in a wrapper of the multiprocessing.Process.join().
-    n_parallel : int = multiprocessing.cpu_count()
+    n_parallel : int = None
         Number of threads used to build in parallel.
+        When the value is -1, will be set to multiprocessing.cpu_count() 
instead

Review comment:
        `-1` should be `None`

##########
File path: python/tvm/auto_scheduler/search_task.py
##########
@@ -118,14 +130,21 @@ def __init__(
         num_measure_trials=0,
         early_stopping=None,
         num_measures_per_round=64,
+        working_dir=None,
+        check_correctness=False,
         verbose=1,
         builder="local",
+        builder_n_parallel=-1,

Review comment:
       The `-1` is conflict with `None` default value before? Could we unify 
the default value (-1 or None) when users don't set.? Currently, I am a bit 
confused with two default values




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to