jwfromm opened a new pull request #7086:
URL: https://github.com/apache/tvm/pull/7086


   Currently relay has separate operators for `reshape` and `reverse_reshape` 
however in c++ they were both implemented using shared functions. The weird 
part is that `ReshapeAttrs` has a `reverse` attribute that was used for 
`reverse_reshape` but not exposed in the python API of `reshape`. This often 
causes headaches when trying to create a new `reshape` operator in a pass from 
existing attributes, since python doesn't expect a `reverse` argument. As far 
as I can tell, there's no reason to have a separate `reverse_reshape` op. 
Consolidating the two and exposing `reverse` in python leads to a much cleaner 
and more obvious API without breaking any tests or use cases.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to