tqchen commented on pull request #7108: URL: https://github.com/apache/tvm/pull/7108#issuecomment-745294179
Thanks @Tristan Konolige for the packed func naming PR. It was on my mind for a while but didn't get to think about all the design tradeoffs. An RFC that quickly polls dev community would be great, specifically there are a few design spectrums(feel free to include these in the rfc): Naming convention: N0: name_hint: might be better name since it does not uniquely identify things N1: name What is the default string: S0: anonymous S1: use a special sub-class of PackedFunc(need to move PackedFunc to object system) S2: always attach Optional<String> since the ref object is relatively cheap, default to nullptr API choices to set the name A0: Allow mutation, add setter API A1: Only allow immutable construction, might affect how we construct from C caallback A2: force to use name_hint, allow idempotent setting, if the name_hint is nullptr, allow set, otherwise allow set only if the new name is same as the old one. Error out if mismatch. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
