mbrookhart commented on a change in pull request #7120:
URL: https://github.com/apache/tvm/pull/7120#discussion_r545285509
##########
File path: include/tvm/relay/dataflow_pattern.h
##########
@@ -46,6 +48,29 @@ class DFPatternNode : public Object {
*/
class DFPattern : public ObjectRef {
public:
+ /*! \brief Syntatic Sugar for creating a CallPattern */
+ DFPattern operator()(const std::vector<DFPattern>& args);
+ /*! \brief Syntatic Sugar for creating a CallPattern with an "add" op */
Review comment:
Hmm. I did the +-*/ overloads in python because Relay's IR does the same
thing at the python level, and I wanted to keep operation on the pattern API in
line with Relay's API. I continued that here, trying to keep the C++ pattern
API in line with the Python Pattern API. So...for consistency I'd argue to
leave it as it is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
