u99127 commented on pull request #7122:
URL: https://github.com/apache/tvm/pull/7122#issuecomment-747688337
> LGTM to the dockerfile and build config. I expect the follow-up PR would
also enable `USE_ARM_COMPUTE_LIB_GRAPH_RUNTIME` to cover ACL runtime unit tests.
>
That is the next step once this is working .Turning that on probably also
needs a bit of tweaking in the infra for the tests which I'll try and fix up
next. The idea was to get the docker changes in and the testing on par with
what happens with the other pipeline but natively.
> On the other hand, I don't think we need to add a new task script for ACL.
The current Jenkinsfile already covers the ACL unit test in L280 (currently
comment out). Specifically, `task_python_integration.sh` covers all the unit
tests under `tests/python/contrib`, including ACL tests. As a result, I would
prefer to bring L280 back in the Jenkinsfile to enable all the tests.
>
As I indicated in the covering letter, turning on task_python_integration.sh
was failing in my test run with failures with tolerances that I suspect will
need more time than I have this side of the holidays.
> Note: Docker image has to be updated after this PR. cc @tqchen
regards
Ramana
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
