junrushao1994 commented on a change in pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#discussion_r547579013
##########
File path: include/tvm/target/tag.h
##########
@@ -139,7 +139,7 @@ inline TargetTagRegEntry& TargetTagRegEntry::set_name() {
}
#define TVM_TARGET_TAG_REGISTER_VAR_DEF \
- static DMLC_ATTRIBUTE_UNUSED ::tvm::TargetTagRegEntry& __make_##TargetTag
+ static __attribute__((unused)) ::tvm::TargetTagRegEntry& __make_##TargetTag
Review comment:
Let's define `TVM_ATTRIBUTE_UNUSED` instead
##########
File path: include/tvm/support/with.h
##########
@@ -65,7 +63,7 @@ class With {
ctx_.EnterWithScope();
}
/*! \brief destructor, leaves the scope of the context. */
- ~With() DMLC_THROW_EXCEPTION { ctx_.ExitWithScope(); }
+ ~With() noexcept(false) { ctx_.ExitWithScope(); }
Review comment:
Let's define `TVM_THROW_EXCEPTION ` instea
##########
File path: CMakeLists.txt
##########
@@ -526,3 +530,25 @@ if(MSVC)
target_compile_definitions(tvm_objs PRIVATE -DTVM_EXPORTS)
target_compile_definitions(tvm_runtime_objs PRIVATE -DTVM_EXPORTS)
endif()
+
+set(IS_DEBUG_BUILD OFF)
Review comment:
let's prefix it with TVM_, like `TVM_IS_DEBUG`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
