yongwww commented on pull request #7137: URL: https://github.com/apache/tvm/pull/7137#issuecomment-750760998
@masahi thanks for the analysis and fix, the use of boxes with negative scores is interesting. Previously, we used `get_valid_counts` before NMS to pre-process boxes, moving invalid boxes to the bottom of box tensor, which helps reduce the computation of NMS by skipping invalid boxes. If negative boxes are valid, then NMS will do computation for all boxes, which causes performance regression. Then we should consider improving the performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
