Laurawly commented on pull request #7146:
URL: https://github.com/apache/tvm/pull/7146#issuecomment-750795971


   > > We should fix the type issue mentioned by @jcf94.
   > > The existing `dense_tensorcore` is buggy in my view. We should fix it 
instead of following it.
   > > This small bug can lead to potential accuracy loss that is very hard to 
debug.
   > 
   > @merrymercy I see your point. Maybe we can discuss it with other tensor 
core maintainers and file another pr to resolve this issue?
   
   I agree with @merrymercy and think we should fix the type issue that we 
overlooked before. We can either fix it in this PR or in a separate parallel 
PR. I'd like to help with that.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to