jcf94 commented on a change in pull request #7161:
URL: https://github.com/apache/tvm/pull/7161#discussion_r548495018



##########
File path: include/tvm/relay/attrs/nn.h
##########
@@ -120,7 +120,7 @@ struct Conv2DAttrs : public tvm::AttrsNode<Conv2DAttrs> {
   tvm::String data_layout;
   tvm::String kernel_layout;
   tvm::String out_layout;
-  std::string auto_scheduler_rewritten_layout;
+  std::string auto_scheduler_rewritten_layout;  // The layout after 
auto-scheduler's layout rewrite

Review comment:
       ```suggestion
     /*! \brief The layout after auto-scheduler's layout rewrite. */
     tvm::String auto_scheduler_rewritten_layout;
   ```
   
   Other members all used `tvm::String`.

##########
File path: include/tvm/relay/attrs/nn.h
##########
@@ -924,6 +924,7 @@ struct AvgPool3DAttrs : public 
tvm::AttrsNode<AvgPool3DAttrs> {
 /*! \brief Attributes for dense operator */
 struct DenseAttrs : public tvm::AttrsNode<DenseAttrs> {
   IndexExpr units;
+  std::string auto_scheduler_rewritten_layout;  // The layout after 
auto-scheduler's layout rewrite

Review comment:
       ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to