merrymercy commented on a change in pull request #7168:
URL: https://github.com/apache/tvm/pull/7168#discussion_r548845290
##########
File path: python/tvm/topi/nn/conv3d.py
##########
@@ -178,7 +207,12 @@ def conv3d_ndhwc(Input, Filter, stride, padding, dilation,
out_dtype="float32"):
),
name="Conv3dOutput",
tag="conv3d_ndhwc",
+ attrs={"layout_free_placeholders": [Filter]},
)
+
+ if auto_scheduler_rewritten_layout:
+ Output = auto_scheduler.rewrite_compute_body(Output,
auto_scheduler_rewritten_layout)
+
return Output
Review comment:
The current style is clearer. For a person who do not want to learn
auto-scheduler, he/she can simply skip any code under branch `if
auto_scheduler_rewritten_layout`.
However, in your style, he/she has to check the code of
`auto_scheduler.rewrite_compute_body` to know the whole logic, which is an
extra burden.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
