tkonolige commented on pull request #7233:
URL: https://github.com/apache/tvm/pull/7233#issuecomment-757009645


   > hmm, this sounds better than picking a random threshold, but do we have 
existing uses of autotvm to make such decision? Given that scatter kernels are 
extern, I'm not sure if autotvm can work with them.
   
   Autotvm does this for external libraries which are all extern, so it will 
work here.
   
   I trust you when you say these are faster, I just wondered if you had done 
any benchmarking. Looking at the code, it seems it should be equally as fast, 
but sometimes it surprises you. That is when benchmarks are useful.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to