tkonolige commented on pull request #7235: URL: https://github.com/apache/tvm/pull/7235#issuecomment-758084048
I've hit problems with not using git-merge-base with git-clang-format in the past, but I can't for the life of me remember the specifics (maybe git-clang-format fixed these issues?). Without merge-base, git-clang-format is doing extra work by trying to format all files changed between merge-base and the tip of main. You just don't see any output because the files were already correctly formatted. Maybe if clang-format was slow this would an issue? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
