masahi commented on pull request #7257: URL: https://github.com/apache/tvm/pull/7257#issuecomment-758961671
Yes, ideally I want to update our NMS to be more closer to TF/ONNX/PyTorch, and let MXNet frontend handle split and concat, rather than the other way around (what we have now). Current API is over complicated due to the need to support both styles. If we can assume that `return_indices` is always True, we can clean up our API a lot. For example, `invalid_to_bottom` argument only makes sense for MXNet. We don't need `coord_start`, `score_index`, and `id_index` arguments, if inputs are only unpacked. Supporting `max_output_boxes_per_class` needs change in the implementation as well. We need to count the number of survived boxes per class. But that's the only change I think, it is definitely doable without writing another kernel. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
