areusch commented on a change in pull request #6950:
URL: https://github.com/apache/tvm/pull/6950#discussion_r556740015
##########
File path: src/relay/backend/contrib/codegen_c/codegen.cc
##########
@@ -229,25 +228,31 @@ class CSourceCodegen : public CSourceModuleCodegenBase {
String func_name = std::get<1>(res);
// Create headers
- code_stream_ << "#include <cstring>\n";
- code_stream_ << "#include <vector>\n";
+ code_stream_ << "#include <stdio.h>\n";
+ code_stream_ << "#include <stdlib.h>\n";
+ code_stream_ << "#include <string.h>\n";
code_stream_ << "#include <tvm/runtime/c_runtime_api.h>\n";
- code_stream_ << "#include <tvm/runtime/container.h>\n";
- code_stream_ << "#include <tvm/runtime/packed_func.h>\n";
- code_stream_ << "#include <dlpack/dlpack.h>\n";
- code_stream_ << "using namespace tvm::runtime;\n";
+ code_stream_ << "#include <tvm/runtime/c_backend_api.h>\n";
+ code_stream_ << "#include <tvm/runtime/crt/module.h>\n";
+ if (!variables.empty()) {
+ // These are only needed to handle metadata copying
+ code_stream_ << "#include <tvm/runtime/container.h>\n";
+ code_stream_ << "#include <tvm/runtime/packed_func.h>\n";
+ code_stream_ << "#include <dlpack/dlpack.h>\n";
+ code_stream_ << "using namespace tvm::runtime;\n";
Review comment:
hrm. should we then add code like:
```
#ifdef __cplusplus
using std::malloc;
#endif
```
you're right this is a demo codegen, perhaps we don't need to resolve this.
it's just confusing to create c++ code in a codegen named codegen_c.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
