masahi commented on a change in pull request #7210:
URL: https://github.com/apache/tvm/pull/7210#discussion_r557784553
##########
File path: src/relay/backend/compile_engine.cc
##########
@@ -593,8 +604,10 @@ class MakeShapeFunc : public
backend::MemoizedExprTranslator<Array<te::Tensor>>
std::unordered_map<Expr, Array<te::Tensor>, ObjectPtrHash, ObjectPtrEqual>
param_data_;
/*! \brief Map from parameter to list of shape placeholder */
std::unordered_map<Expr, Array<te::Tensor>, ObjectPtrHash, ObjectPtrEqual>
param_shapes_;
- /*! \brief Stack of data dependencies for shape function */
+ /*! \brief Stack of data dependencies for shape function, specified per op */
std::vector<bool> data_dependants_;
Review comment:
ok I'll try removing `data_dependants_`.
Right, I was not sure `dependant` was intentional or not... It's actually
everywhere (grep `dependant` gives many hit). I'll fix them all!!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
