manupa-arm commented on pull request #6950: URL: https://github.com/apache/tvm/pull/6950#issuecomment-760798261
Hi @areusch @zhiics , I've addressed all the minor comments. The current limitation of making this generator a pure C code generator is that is carries a Array\<NDArray\> for constants that will be copied in, if required by the compilation pipeline. I feel changing this is a bigger work and its only there to test the external codegen/runtime pathway (especially the JSONRuntime) handles the constant copying. Therefore, given that we have Array\<NDArray\>, I might as well use the macro. However, I clearly commented and made it obvious that bit of the code is C++ (using ifdef __cplusplus as @areusch suggested.) Therefore, in the absense of the constant copying, this will generate a pure C code -- If you see I have removed macro usage for the main compute function (its just the constant copying one uses it). Let me know your thoughts and what more could be done about it, if any. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
