altanh commented on pull request #7295: URL: https://github.com/apache/tvm/pull/7295#issuecomment-761217256
not the fault of this PR, but I've noticed some confusing and inconsistent usage of `src` and `dst` in different `Unify` functions (along with non-matching implementation argument names). There might even be a slight bug where the order is exchanged in `TypeSolver` vs `TypeSolver::Unifier`, not sure if this affects correctness. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
