tqchen commented on a change in pull request #7306:
URL: https://github.com/apache/tvm/pull/7306#discussion_r559854513



##########
File path: python/tvm/tir/ir_builder.py
##########
@@ -249,17 +249,17 @@ def for_range(self, begin, end, name="i", dtype="int32", 
for_type="serial"):
         extent = end if begin == 0 else (end - begin)
 
         def _exit_cb():
-            if for_type == "serial":
-                for_type_id = 0
-            elif for_type == "parallel":
-                for_type_id = 1
-            elif for_type == "vectorize":
-                for_type_id = 2
-            elif for_type == "unroll":
-                for_type_id = 3
+            if kind == "serial":
+                kind_id = 0
+            elif kind == "parallel":
+                kind_id = 1
+            elif kind == "vectorize":
+                kind_id = 2
+            elif kind == "unroll":
+                kind_id = 3

Review comment:
       We are trying to be consistent with the old API for now. So let us keep 
it as it is. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to