tqchen edited a comment on pull request #7309:
URL: https://github.com/apache/tvm/pull/7309#issuecomment-763036932
The deletion on non-virtual destructor is fine as long as they are held via
ObjectPtr (the deleter is stored inside the object itself).
Unfortunately directly printing out the first element's type is not
sufficient in this case. Think about the following example
```python
X = { key0: v0, key1: v1 }
```
If key0 and key1 belongs to different types. e.g. key0 is IntImm, and key1
is Add. and the Map is `Map<PrimExpr, Value>`, but will print as `Map<IntImm,
Value>`. A middle ground should be printing the actual value that mismatches.
e.g. key1 is the one that mismatches, printing out the type under that
particular value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
