tkonolige commented on a change in pull request #7267:
URL: https://github.com/apache/tvm/pull/7267#discussion_r562220135
##########
File path: python/tvm/relay/frontend/tensorflow.py
##########
@@ -942,7 +942,10 @@ def _impl(inputs, attr, params, mod):
)
if sparse_lhs:
- data = _op.transpose(data)
+ if attr.get("adjoint_a"):
Review comment:
This logic is very confusing. I've looked over it a couple of time and
I'm still not sure if it is correct. How about you document all the cases like
this:
```
A B -> (B.T A.T).T -> transpose(sparse_dense(transpose(B), A,
sparse_lhs=false))
A B.T -> ??
A.T B -> ??
A.T B.T -> ??
```
And then you can make a series of if statements that match these cases.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
