areusch commented on a change in pull request #7331:
URL: https://github.com/apache/tvm/pull/7331#discussion_r564727395
##########
File path: python/tvm/target/target.py
##########
@@ -234,7 +234,10 @@ def micro(model="unknown", options=None):
trans_table = {
"host": [],
"stm32f746xx": ["-mcpu=cortex-m7", "-march=armv7e-m"],
+ "nrf5340dk": ["-keys=arm_cpu", "-mcpu=cortex-m33"],
Review comment:
I think this was because we originally intended to enable ARM schedules
based on `-march`. i think this was because i had read some documentation that
`-march` was the proper way to specify ISA, but it turns out that this is just
specific to x86 targets. For ARM targets, it seems `-mcpu` is actually
canonical. So, we may need to improve our ISA parser to handle both.
Actually I think `-keys` here is also unnecessary--my apologies. @mdw-octoml
can you remove that? I believe it should get auto-added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
