slyubomirsky commented on pull request #7318: URL: https://github.com/apache/tvm/pull/7318#issuecomment-769545493
@comaniac @zhiics I'm not sure I quite understand how let nodes are being handled in the code. I think the reason for the weird behavior in the given test case is that when you have `let %x = [body expression] in %x`, `InsertCompilerEndAndPropogateTarget()` just skips over the `%x` in the body statement, resulting in the current output. Would we want the final `%x` to have its own `compiler_begin` and `compiler_end`? Or would we want the body expression to begin a compiler region and the final `%x` to contain a `compiler_end`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
