mdw-octoml commented on a change in pull request #7289:
URL: https://github.com/apache/tvm/pull/7289#discussion_r568062188
##########
File path: python/setup.py
##########
@@ -171,38 +171,25 @@ def get_package_data_files():
return ["relay/std/prelude.rly", "relay/std/core.rly"]
+# Temporarily add this directory to the path so we can import the requirements
generator
+# tool.
+sys.path.insert(0, os.path.dirname(__file__))
+import gen_requirements
+sys.path.pop(0)
+
+requirements = gen_requirements.join_requirements()
Review comment:
Well, just a suggestion that when this is being invoked, and the
requirements being generated automatically, it might be useful to have them
dumped to stdout during the invocation (perhaps optionally) so someone
debugging issues with Python deps can readily see what they were. Not sure if
they are exposed in an obvious way elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
