leandron commented on a change in pull request #7304: URL: https://github.com/apache/tvm/pull/7304#discussion_r570886224
########## File path: python/tvm/driver/tvmc/byoc.py ########## @@ -0,0 +1,191 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +""" +Provides support to Bring Your Own Codegen (BYOC) on TVMC. +""" +import logging + +from abc import ABC +from abc import abstractmethod + +import tvm + +from tvm import relay + +from tvm.relay.op.contrib import get_pattern_table + +from .common import TVMCException + + +# pylint: disable=invalid-name +logger = logging.getLogger("TVMC") Review comment: The linter consider this is a constant, and should be all capitals. This `logger = ` _pattern_ is used all across the TVM Python code base, usually with a blanket, per file disabling comment like `# pylint: disable=invalid-name,unused-variable,unused-argument`. I try to keep pylint disables to the narrowest scope possible, that's why it is disabled like this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
