tkonolige commented on a change in pull request #7417:
URL: https://github.com/apache/tvm/pull/7417#discussion_r571329085



##########
File path: CMakeLists.txt
##########
@@ -371,10 +371,10 @@ endif()
 
 add_lib_info(${CMAKE_CURRENT_LIST_DIR}/src/support/libinfo.cc)
 
-add_library(tvm_objs OBJECT ${COMPILER_SRCS} ${RUNTIME_SRCS})
+add_library(tvm_objs OBJECT ${COMPILER_SRCS})
 add_library(tvm_runtime_objs OBJECT ${RUNTIME_SRCS})
 
-add_library(tvm SHARED $<TARGET_OBJECTS:tvm_objs>)
+add_library(tvm SHARED $<TARGET_OBJECTS:tvm_objs> 
$<TARGET_OBJECTS:tvm_runtime_objs>)

Review comment:
       got that one in the second commit




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to