echuraev commented on pull request #7391: URL: https://github.com/apache/tvm/pull/7391#issuecomment-775732937
@mbrookhart, @masahi, I have one question about implementation of `exclusive` attribute. In current implementation, I added this attribute to topi kernels, but also I could do the same thing only for ONNX frontend (by adding `subtract` operation after `cumsum`). What do you think, what is the better approach? In first case we don't have overhead of `subtract` operation, but in the second we should write less code. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
