comaniac commented on pull request #7428: URL: https://github.com/apache/tvm/pull/7428#issuecomment-776139417
Thanks for the PR. Regard to the current AnnotateTarget pass for BYOC, I have some questions/comments: - From the use case, it looks like very similar to the `compiler_begin` and `compiler_end`, but limits to per node. Could you ellaborate the reason why not using `compiler_begin` and `compiler_end` directly? - This PR doesn't include a pass to annotate nodes but relies on manual annotation. Could you ellaborate how would you expect users to use them? - If we use `compiler_begin` and `compiler_end`, it seems possible to extend existing AnnotateTarget to annotate non-external compilers. The current AnnotateTarget annotates rest nodes to CPU. We could refactor that pass and make CPU and GPU as two "external" compilers as well so that AnnotateTarget could also take care of them. I feel that we should only maintain one annotation mechanism at the end, so whatever which approach we finally agree on, we could also refactor BYOC AnnotateTarget pass in that way. Also cc @zhiics ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
