tkonolige commented on a change in pull request #7153:
URL: https://github.com/apache/tvm/pull/7153#discussion_r573255711
##########
File path: CMakeLists.txt
##########
@@ -379,6 +386,26 @@ set_property(TARGET tvm APPEND PROPERTY LINK_OPTIONS
"${TVM_VISIBILITY_FLAG}")
add_library(tvm_runtime SHARED $<TARGET_OBJECTS:tvm_runtime_objs>)
set_property(TARGET tvm_runtime APPEND PROPERTY LINK_OPTIONS
"${TVM_VISIBILITY_FLAG}")
+target_compile_definitions(tvm_objs PUBLIC
DMLC_USE_LOGGING_LIBRARY=<tvm/runtime/logging.h>)
+target_compile_definitions(tvm_runtime_objs PUBLIC
DMLC_USE_LOGGING_LIBRARY=<tvm/runtime/logging.h>)
+target_compile_definitions(tvm PUBLIC
DMLC_USE_LOGGING_LIBRARY=<tvm/runtime/logging.h>)
+target_compile_definitions(tvm_runtime PUBLIC
DMLC_USE_LOGGING_LIBRARY=<tvm/runtime/logging.h>)
Review comment:
The logging libraries are part of TVM, so I think the define should go
there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
