leandron commented on a change in pull request #7400:
URL: https://github.com/apache/tvm/pull/7400#discussion_r573808458
##########
File path: python/tvm/relay/frontend/tflite.py
##########
@@ -3539,7 +3539,45 @@ def get_tensor_name(subgraph, tensor_idx):
return subgraph.Tensors(tensor_idx).Name().decode("utf-8")
-def from_tflite(model, shape_dict, dtype_dict):
+def _decode_type(n):
+ _tflite_m = {
Review comment:
I see this is duplicated in tvmc/frontends.py - is there any reason why
we can't reuse this one there?
##########
File path: python/tvm/driver/tvmc/frontends.py
##########
@@ -241,43 +241,10 @@ def load(self, path, shape_dict=None):
if version != 3:
raise TVMCException("input file not tflite version 3")
- logger.debug("tflite_input_type")
- input_shapes, dtype_dict = TFLiteFrontend._input_type(tflite_model)
- if shape_dict is not None:
- input_shapes.update(shape_dict)
-
logger.debug("parse TFLite model and convert into Relay computation
graph")
- mod, params = relay.frontend.from_tflite(
- tflite_model, shape_dict=input_shapes, dtype_dict=dtype_dict
- )
+ mod, params = relay.frontend.from_tflite(tflite_model)
Review comment:
Since we merged #7366, users are able to provide shapes in tvmc from
outside, can you have a look on that one and adjust?
```suggestion
mod, params = relay.frontend.from_tflite(tflite_model,
shape_dict=input_shapes, dtype_dict=dtype_dict)
```
cc @CircleSpin @hogepodge to help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
