trevor-m commented on a change in pull request #7436:
URL: https://github.com/apache/tvm/pull/7436#discussion_r574065135
##########
File path: cmake/modules/contrib/TensorRT.cmake
##########
@@ -28,7 +28,9 @@ if(USE_TENSORRT_CODEGEN)
file(GLOB RUNTIME_TENSORRT_SRCS
src/runtime/contrib/tensorrt/tensorrt_runtime.cc)
set_source_files_properties(${RUNTIME_TENSORRT_SRCS} PROPERTIES
COMPILE_FLAGS "-Wno-deprecated-declarations")
list(APPEND COMPILER_SRCS ${COMPILER_TENSORRT_SRCS})
- list(APPEND COMPILER_SRCS ${RUNTIME_TENSORRT_SRCS})
+ if(NOT USE_TENSORRT_RUNTIME)
+ list(APPEND COMPILER_SRCS ${RUNTIME_TENSORRT_SRCS})
Review comment:
I see, I think that accomplishes the exact same thing as this change,
but instead of conditionally adding tensorrt_runtime.cc in
USE_TERSORRT_CODEGEN, it would be conditionally excluding it in
USE_TENSORRT_RUNTIME if its already included by USE_TERSORRT_CODEGEN
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
