binarybana commented on pull request #7454: URL: https://github.com/apache/tvm/pull/7454#issuecomment-778827836
Perhaps another guard for the nthread == 1 case at this point? https://github.com/apache/tvm/blob/18fdf41150511f6562ba8904b5519c5950bc0e93/src/runtime/threading_backend.cc#L85 Though it feels weird to be using a threadpool at all for the nthread == 1 case. Also, unrelated, but saw this while looking around this code: I'm probably just reading this wrong, but to me the below line looks odd: why is the `kBig` mode hardcoded here? https://github.com/apache/tvm/blob/18fdf41150511f6562ba8904b5519c5950bc0e93/src/runtime/thread_pool.cc#L273 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
